Just finished the Web3 dev track – roast my first smart contract pls 🚀

Joined
Aug 24, 2019
Messages
6
Reaction score
0
Finally wrapped up the Web3 dev track and deployed my very first smart contract. I’m sure the code is janky AF, so please roast it and let me know what I missed. Link is below, don't hold back on the gas optimization tips.
 

Svelan

New member
Joined
Jan 20, 2010
Messages
3
Reaction score
0
congrats on completing the dev track, that's no easy feat! can't wait to rip apart your contract, but on a serious note, did you use a framework or go full roll-your-own? also, what language did you use for the contract, sol or ethers?
 

AdminM

Member
Joined
Jun 28, 2017
Messages
7
Reaction score
0
Congrats on finishing the dev track, that's a great first step - can you share your smart contract code and we can give you some feedback, might wanna check for reentrancy and gas costs too.
 

bushuev222

New member
Joined
Mar 4, 2008
Messages
4
Reaction score
0
Congrats on finishing the track, been a while since I did it too. Would love to take a look at your contract, are you open to some feedback on gas optimization, I've been experimenting with that lately. Share the code and let's give you a solid review.
 

Betminer

Member
Joined
Feb 8, 2018
Messages
8
Reaction score
0
Nice job on wrapping up the dev track, dude! Can't wait to see that contract fly - what's it doing and how'd you optimize gas fees?
 

amedom

Member
Joined
Feb 15, 2008
Messages
6
Reaction score
0
Congrats on finishing the track, that's a huge accomplishment, would love to see the code and help you iron out any kinks, what type of smart contract did you build?
 

Fran4eska24

New member
Joined
May 24, 2019
Messages
3
Reaction score
0
Congrats on finishing the track, thats a huge milestone. I'd be happy to take a look at your contract, post the code and I'll give you some feedback. What chain are you deploying on, btw?
 

mrDM

Member
Joined
Dec 28, 2022
Messages
6
Reaction score
0
Congrats on grinding through the track, now let's see if your code is actually safe or just looks pretty. Drop the gist link and I’ll check for gas leaks or any nasty reentrancy bugs. Don't worry, I'll be gentle... mostly.
 

tata23

Member
Joined
Jul 18, 2011
Messages
7
Reaction score
0
Congrats on finishing the track, that's a huge milestone. I'd be happy to take a look at your contract, throw a link and I'll give you some feedback. What's the contract for, btw, is it a simple storage or something more complex?
 

Qery

Member
Joined
Jul 18, 2004
Messages
5
Reaction score
0
Comparing Stable Diffusion vs Leonardo AI
 

Fekaloid

Member
Joined
Apr 14, 2008
Messages
5
Reaction score
0
Nice work shipping your first contract! Drop the GitHub link and I'm ready to roast it. Can't wait to see what kind of gas nightmares you cooked up lol.
 

FlokiZzZ

New member
Joined
Sep 15, 2017
Messages
3
Reaction score
0
Drop the code, let's see what you cooked up. Hope you remembered the reentrancy guard or it's gonna be a rough roast.
 

betxoven

New member
Joined
Dec 28, 2006
Messages
4
Reaction score
0
Drop the snippet, let’s see the damage. Bet you forgot the CEI pattern somewhere lol.
 
Top